From ce498470531415c7c8161f6ca063c473f8124420 Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Tue, 22 Apr 2008 01:05:15 +0000 Subject: [PATCH] (bug 13816) Filter by main namespace doesn't work on WhatLinksHere. Guess why? Weak PHP typing! I want to assemble a list of all these bugs as a concrete example of why PHP sucks. --- RELEASE-NOTES | 1 + includes/FormOptions.php | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 5e1ebcb36a..e6081eec3e 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -208,6 +208,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * Fix fatal error on calling PAGESINCATEGORY with invalid category name * (bug 13793) Special:Whatlinkshere filters wrong - after paginating instead of before * (bug 13796) Show links to parent pages even if some of them are missing +* (bug 13816) Filter by main namespace doesn't work on WhatLinksHere === API changes in 1.13 === diff --git a/includes/FormOptions.php b/includes/FormOptions.php index f708b4a861..8c7849e8e6 100644 --- a/includes/FormOptions.php +++ b/includes/FormOptions.php @@ -154,10 +154,10 @@ class FormOptions { throw new MWException( 'Unsupported datatype' ); } - if ( $value !== $default && $value != null ) { + if ( $value !== $default && $value !== null ) { $this->options[$name]['value'] = $value; } } } -} \ No newline at end of file +} -- 2.20.1